netdev - [PATCH v2 net] vmxnet3: remove incorrect register dump of RX data ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250920120732.351640-1-alok.a.tiwari@oracle.com>
Date: Sat, 20 Sep 2025 05:07:18 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: sankararaman.jayaraman@...adcom.com, ronak.doshi@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, andrew+netdev@...n.ch,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org
Cc: alok.a.tiwari@...cle.com
Subject: [PATCH v2 net] vmxnet3: remove incorrect register dump of RX data ring

The ethtool get_regs() implementation incorrectly dumps
rq->rx_ring[0].size in the RX data ring section. rq->rx_ring[0].size
belongs to the RX descriptor ring, not the data ring, and is already
reported earlier. The RX data ring only defines desc_size, which is
already exported.

Remove the redundant and invalid rq->rx_ring[0].size dump to avoid
confusing or misleading ethtool -d output.

Fixes: 50a5ce3e7116 ("vmxnet3: add receive data ring support")
Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
---
v1 -> v2
correct fixes tag reference.
---
 drivers/net/vmxnet3/vmxnet3_ethtool.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
index cc4d7573839d..82f5a6156178 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -598,7 +598,6 @@ vmxnet3_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *p)
 
 		buf[j++] = VMXNET3_GET_ADDR_LO(rq->data_ring.basePA);
 		buf[j++] = VMXNET3_GET_ADDR_HI(rq->data_ring.basePA);
-		buf[j++] = rq->rx_ring[0].size;
 		buf[j++] = rq->data_ring.desc_size;
 
 		buf[j++] = VMXNET3_GET_ADDR_LO(rq->comp_ring.basePA);
-- 
2.50.1