netdev - Re: [PATCH v2 net] vmxnet3: remove incorrect register dump of RX data ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ea307d6-13c0-407f-8275-50712f95e225@lunn.ch>
Date: Sat, 20 Sep 2025 17:41:08 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: sankararaman.jayaraman@...adcom.com, ronak.doshi@...adcom.com,
	bcm-kernel-feedback-list@...adcom.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] vmxnet3: remove incorrect register dump of RX
 data ring

On Sat, Sep 20, 2025 at 05:07:18AM -0700, Alok Tiwari wrote:
> The ethtool get_regs() implementation incorrectly dumps
> rq->rx_ring[0].size in the RX data ring section. rq->rx_ring[0].size
> belongs to the RX descriptor ring, not the data ring, and is already
> reported earlier. The RX data ring only defines desc_size, which is
> already exported.
> 
> Remove the redundant and invalid rq->rx_ring[0].size dump to avoid
> confusing or misleading ethtool -d output.

ethtool get_regs() is an ABI. Please can you add an explanation why
this is a safe change to make, it does not affect the ABI.


    Andrew

---
pw-bot: cr