netdev - Re: [PATCH net-next 02/20] net: Add peer to netdev_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edc230c2-1079-4439-8bb8-ac73135c8f7e@davidwei.uk>
Date: Tue, 23 Sep 2025 08:56:22 -0700
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>, Daniel Borkmann <daniel@...earbox.net>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
 razor@...ckwall.org, pabeni@...hat.com, willemb@...gle.com, sdf@...ichev.me,
 john.fastabend@...il.com, martin.lau@...nel.org, jordan@...fe.io,
 maciej.fijalkowski@...el.com, magnus.karlsson@...el.com
Subject: Re: [PATCH net-next 02/20] net: Add peer to netdev_rx_queue

On 2025-09-22 18:22, Jakub Kicinski wrote:
> On Fri, 19 Sep 2025 23:31:35 +0200 Daniel Borkmann wrote:
>> +static inline void netdev_rx_queue_peer(struct net_device *src_dev,
>> +					struct netdev_rx_queue *src_rxq,
>> +					struct netdev_rx_queue *dst_rxq)
>> +{
>> +	dev_hold(src_dev);
> 
> netdev_hold() is required for all new code

Got it, will update.

> 
>> +	__netdev_rx_queue_peer(src_rxq, dst_rxq);
> 
> Also please avoid static inlines if you need to call a func from
> another header. It complicates header dependencies.

Didn't know this, thanks, will fix.