netdev - Re: [PATCH net-next v2 1/6] bnxt_en: Move common definitions to include/linux/bnxt/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv1yFO+izik3_Bssvg4q48k-fe7adrgv6E-gtPkaZjcgSQ@mail.gmail.com>
Date: Tue, 23 Sep 2025 23:30:10 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Saeed Mahameed <saeed@...nel.org>
Cc: jgg@...pe.ca, michael.chan@...adcom.com, dave.jiang@...el.com, 
	saeedm@...dia.com, Jonathan.Cameron@...wei.com, davem@...emloft.net, 
	corbet@....net, edumazet@...gle.com, gospo@...adcom.com, kuba@...nel.org, 
	netdev@...r.kernel.org, pabeni@...hat.com, andrew+netdev@...n.ch, 
	selvin.xavier@...adcom.com, leon@...nel.org, 
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net-next v2 1/6] bnxt_en: Move common definitions to include/linux/bnxt/

On Tue, Sep 23, 2025 at 10:46 PM Pavan Chebbi <pavan.chebbi@...adcom.com> wrote:
>
> >
> > This file is redundant since ulp.h already holds every thing "aux", so this
> > struct belongs there. Also the only place you include this is file:
> >    drivers/net/ethernet/broadcom/bnxt/bnxt.h
>
> Hi Saeed, later bnxt fwctl will include it as well. You could say it
> can still be
> inside ulp.h but fwctl is only going to need bnxt_aux_priv. So I
> carved it out of
> earlier bnxt.h.
>
On second thought, the struct might not have belonged to bnxt.h in the
first place.
So moving it to ulp.h seems like a better thing to do. Thanks.