netdev - Re: [PATCH net-next v2 1/6] bnxt_en: Move common definitions to include/linux/bnxt/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv0F+RW8gFu83=1-PfdbT7Eyfy6Kb2FYiAP3JhuVw7Jo7Q@mail.gmail.com>
Date: Tue, 23 Sep 2025 22:46:55 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Saeed Mahameed <saeed@...nel.org>
Cc: jgg@...pe.ca, michael.chan@...adcom.com, dave.jiang@...el.com, 
	saeedm@...dia.com, Jonathan.Cameron@...wei.com, davem@...emloft.net, 
	corbet@....net, edumazet@...gle.com, gospo@...adcom.com, kuba@...nel.org, 
	netdev@...r.kernel.org, pabeni@...hat.com, andrew+netdev@...n.ch, 
	selvin.xavier@...adcom.com, leon@...nel.org, 
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net-next v2 1/6] bnxt_en: Move common definitions to include/linux/bnxt/

.

On Tue, Sep 23, 2025 at 10:03 PM Saeed Mahameed <saeed@...nel.org> wrote:

> >diff --git a/include/linux/bnxt/common.h b/include/linux/bnxt/common.h
> >new file mode 100644
> >index 000000000000..2ee75a0a1feb
> >--- /dev/null
> >+++ b/include/linux/bnxt/common.h
> >@@ -0,0 +1,20 @@
> >+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> >+/*
> >+ * Copyright (c) 2025, Broadcom Corporation
> >+ *
> >+ */
> >+
> >+#ifndef BNXT_COMN_H
> >+#define BNXT_COMN_H
> >+
> >+#include <linux/bnxt/hsi.h>
> >+#include <linux/bnxt/ulp.h>
> >+#include <linux/auxiliary_bus.h>
> >+
> >+struct bnxt_aux_priv {
> >+      struct auxiliary_device aux_dev;
> >+      struct bnxt_en_dev *edev;
> >+      int id;
> >+};
> >+
>
> This file is redundant since ulp.h already holds every thing "aux", so this
> struct belongs there. Also the only place you include this is file:
>    drivers/net/ethernet/broadcom/bnxt/bnxt.h

Hi Saeed, later bnxt fwctl will include it as well. You could say it
can still be
inside ulp.h but fwctl is only going to need bnxt_aux_priv. So I
carved it out of
earlier bnxt.h.

>
> So I am not sure if you have your include paths properly setup to avoid
> cross subsystem includes, in-case this was the point of this patch :).
>
> >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h b/include/linux/bnxt/ulp.h
> >similarity index 100%
> >rename from drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h
> >rename to include/linux/bnxt/ulp.h
> >--
> >2.39.1
> >
> >