netdev - Re: [PATCH] net: phy: bcm5481x: Fix GMII/MII/MII-Lite selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f990710b-dc65-4f03-bece-70dd0ff8f431@lunn.ch>
Date: Tue, 23 Sep 2025 18:46:07 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Kamil Horák - 2N <kamilh@...s.com>,
	bcm-kernel-feedback-list@...adcom.com, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: bcm5481x: Fix GMII/MII/MII-Lite selection

> > > +	if (!phy_interface_is_rgmii(phydev)) {
> > > +		/* Misc Control: GMII/MII/MII-Lite Mode (not RGMII) */
> > > +		err = bcm54xx_auxctl_write(phydev, MII_BCM54XX_AUXCTL_SHDWSEL_MISC,
> > > +					   MII_BCM54XX_AUXCTL_MISC_WREN |
> > > +					   MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RGMII_SKEW_EN |
> > 
> > This is a bit confusing. If it is NOT RGMII, you set RGMII_SKEW_EN? I
> > could understand the opposite, clear the bit...
> 
> Bit 7 is documented as RGMII Enable

Thanks Florian

However, this still does not explain the
!phy_interface_is_rgmii(phydev).

	 Andrew