netdev - Re: [PATCH net-next v5 1/5] ethtool: add FEC bins histogram report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250923172748.7269e6f7@kernel.org>
Date: Tue, 23 Sep 2025 17:27:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Andrew Lunn <andrew@...n.ch>, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, intel-wired-lan@...ts.osuosl.org, Donald
 Hunter <donald.hunter@...il.com>, Carolina Jubran <cjubran@...dia.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 1/5] ethtool: add FEC bins histogram report

On Mon, 22 Sep 2025 10:07:37 +0000 Vadim Fedorenko wrote:
> +		if (j && nla_put_64bit(skb, ETHTOOL_A_FEC_HIST_BIN_VAL_PER_LANE,
> +				       sizeof(u64) * j,
> +				       values[i].per_lane,
> +				       ETHTOOL_A_FEC_STAT_PAD))

The pad attribute needs to be from the same attr space as the attr
you're outputting. You need to create your own pad attr in the spec.