netdev - Re: [PATCH net-next v5 3/5] net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250923173438.70295e44@kernel.org>
Date: Tue, 23 Sep 2025 17:34:38 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Andrew Lunn <andrew@...n.ch>, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, intel-wired-lan@...ts.osuosl.org, Donald
 Hunter <donald.hunter@...il.com>, Carolina Jubran <cjubran@...dia.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, Yael Chemla <ychemla@...dia.com>, Dragos Tatulea
 <dtatulea@...dia.com>
Subject: Re: [PATCH net-next v5 3/5] net/mlx5e: Add logic to read RS-FEC
 histogram bin ranges from PPHCR

On Mon, 22 Sep 2025 10:07:39 +0000 Vadim Fedorenko wrote:
> +#define MLX5E_FEC_RS_HIST_MAX 16

I'm guessing you insist on the checks because 
struct mlx5_ifc_rs_histogram_cntrs_bits hardcodes the size of the hist array as 16.
Please make this define use ARRAY_SIZE() or some such, instead of this
random looking number.