netdev - Re: [PATCH net-next 2/9] selftests: net: add skip all feature to ksft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e099b09-75d3-437b-a1d3-ed964032f9b6@gmail.com>
Date: Thu, 25 Sep 2025 13:04:23 -0400
From: Daniel Zahka <daniel.zahka@...il.com>
To: Petr Machata <petrm@...dia.com>
Cc: Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Shuah Khan <shuah@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
 Breno Leitao <leitao@...ian.org>, Yuyang Huang <yuyanghuang@...gle.com>,
 Xiao Liang <shaw.leon@...il.com>, Carolina Jubran <cjubran@...dia.com>,
 Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/9] selftests: net: add skip all feature to
 ksft_run()

On 9/25/25 12:09 PM, Petr Machata wrote:
> Personally I'm not very fond of this. Calling a run helper just to have
> it skip all tests... eh, wouldn't it make more sense to just not call
> the function at all then? If all tests have PSP as prereq, just have the
> test say so and bail out early?
>
> Topic-specific tests are pretty common, so it's not nonsense to have a
> facility that supports that. But this API just seems wrong to me. Run
> these tests, except don't run them, just show they are all skipped.

That's fair. I will change that for the next posting. Thanks for taking 
a look.