netdev - Re: [PATCH net-next 2/9] selftests: net: add skip all feature to ksft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250925191821.7adfbdb4@kernel.org>
Date: Thu, 25 Sep 2025 19:18:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: Daniel Zahka <daniel.zahka@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>, Willem de Bruijn
 <willemb@...gle.com>, Breno Leitao <leitao@...ian.org>, Yuyang Huang
 <yuyanghuang@...gle.com>, Xiao Liang <shaw.leon@...il.com>, Carolina Jubran
 <cjubran@...dia.com>, Donald Hunter <donald.hunter@...il.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/9] selftests: net: add skip all feature to
 ksft_run()

On Thu, 25 Sep 2025 18:09:33 +0200 Petr Machata wrote:
> > +            if skip_all:
> > +                raise KsftSkipEx()
> >              case(*args)
> >          except KsftSkipEx as e:
> >              comment = "SKIP " + str(e)  
> 
> Personally I'm not very fond of this. Calling a run helper just to have
> it skip all tests... eh, wouldn't it make more sense to just not call
> the function at all then? If all tests have PSP as prereq, just have the
> test say so and bail out early?

Yes, good call. To be clear this was my bad idea, I think I wrote this
before the ksft took shape upstream. My tree says:

Date:   Tue Apr 16 12:02:59 2024 -0700

on the patch from which this was factored out. So let's chalk this
lapse of reason to experimentation :)