netdev - Re: [PATCH net-next] Wangxun: vf: Implement some ethtool apis for get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250925092216.GA836419@horms.kernel.org>
Date: Thu, 25 Sep 2025 10:22:16 +0100
From: Simon Horman <horms@...nel.org>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
Cc: netdev@...r.kernel.org, jiawenwu@...stnetic.com,
	duanqiangwen@...-swift.com, linglingzhang@...stnetic.com
Subject: Re: [PATCH net-next] Wangxun: vf: Implement some ethtool apis for
 get_xxx

On Wed, Sep 24, 2025 at 04:21:40PM +0800, Mengyuan Lou wrote:
> Implement some ethtool interfaces for obtaining the status of
> Wangxun Virtual Function Ethernet.
> Just like connection status, version information, queue depth and so on.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>

Hi Mengyuan Lou,

To my mind this patch, although small is doing quite a few things.

1. Adding ethtool code to libwx
2. Using 1 in two drivers
3. Adding a wx_get_fw_version_vf() call to two drivers

To be honest I would probably have split this up a bit.
Especially 3. But perhaps that is just me.

Also, I think that, as things stand, "net: wangxun: " would be a more
appropriate prefix for the title of the patch.

So if you do decide to re-spin, please consider the above.

But regardless, the code looks fine to me.

Reviewed-by: Simon Horman <horms@...nel.org>

...