netdev - Re: [PATCH v3 net-next] tipc: adjust tipc_nodeid2string() to check the length of the result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNazz8tpiCeFi9KZ@horms.kernel.org>
Date: Fri, 26 Sep 2025 16:39:59 +0100
From: Simon Horman <horms@...nel.org>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Jon Maloy <jmaloy@...hat.com>, "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Tung Quang Nguyen <tung.quang.nguyen@....tech>,
	tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next] tipc: adjust tipc_nodeid2string() to check
 the length of the result

On Thu, Sep 25, 2025 at 07:51:46PM +0300, Dmitry Antipov wrote:
> Since the value returned by 'tipc_nodeid2string()' is not used, the
> function may be adjusted to check the length of the result against
> NODE_ID_LEN, which is helpful to drop a few calls to 'strlen()' and
> simplify 'tipc_link_create()' and 'tipc_link_bc_create()'. Compile
> tested only.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@...dex.ru>
> ---
> v3: convert to check against NODE_ID_LEN (Simon Horman)
> v2: adjusted to target net-next (Tung Quang Nguyen)

Reviewed-by: Simon Horman <horms@...nel.org>