netdev - Re: [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return string length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNa0J14NdhrTus4S@horms.kernel.org>
Date: Fri, 26 Sep 2025 16:41:27 +0100
From: Simon Horman <horms@...nel.org>
To: Tung Quang Nguyen <tung.quang.nguyen@....tech>
Cc: Dmitry Antipov <dmantipov@...dex.ru>, Jon Maloy <jmaloy@...hat.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	"tipc-discussion@...ts.sourceforge.net" <tipc-discussion@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return
 string length

On Fri, Sep 26, 2025 at 10:29:31AM +0000, Tung Quang Nguyen wrote:
> >Subject: [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return string
> >length
> >
> >Since the value returned by 'tipc_nodeid2string()' is not used, the function may
> >be adjusted to return the length of the result, which is helpful to drop a few
> >calls to 'strlen()' in 'tipc_link_create()'
> >and 'tipc_link_bc_create()'. Compile tested only.
> >
> >Signed-off-by: Dmitry Antipov <dmantipov@...dex.ru>
> >---
> >v4: revert to v2's behavior and prefer NODE_ID_LEN over
> >    explicit constant (Tung Quang Nguyen)
> >v3: convert to check against NODE_ID_LEN (Simon Horman)
> >v2: adjusted to target net-next (Tung Quang Nguyen)

Reviewed-by: Simon Horman <horms@...nel.org>