netdev - RE: [Intel-wired-lan] [PATCH net-next] ixgbe: fix typos and docstring inconsistencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89867A09E4445E909EBAD679E51BA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 29 Sep 2025 12:49:58 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "horms@...nel.org"
	<horms@...nel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next] ixgbe: fix typos and docstring
 inconsistencies



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Alok Tiwari
> Sent: Monday, September 29, 2025 2:44 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; andrew+netdev@...n.ch;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; netdev@...r.kernel.org; horms@...nel.org; intel-
> wired-lan@...ts.osuosl.org
> Cc: alok.a.tiwari@...cle.com
> Subject: [Intel-wired-lan] [PATCH net-next] ixgbe: fix typos and
> docstring inconsistencies
> 
> Corrected function and variable name typos in comments and docstrings:
>  ixgbe_write_ee_hostif_X550 -> ixgbe_write_ee_hostif_data_X550
> ixgbe_get_lcd_x550em -> ixgbe_get_lcd_t_x550em  "Determime" ->
> "Determine"
>  "point to hardware structure" -> "pointer to hardware structure"
>  "To turn on the LED" -> "To turn off the LED"
> 
> These changes improve readability, consistency.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> index 650c3e522c3e..76d2fa3ef518 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
> @@ -1163,7 +1163,7 @@ static int
> ixgbe_validate_eeprom_checksum_X550(struct ixgbe_hw *hw,
>  	return status;
>  }
> 
> -/** ixgbe_write_ee_hostif_X550 - Write EEPROM word using hostif
> +/** ixgbe_write_ee_hostif_data_X550 - Write EEPROM word using hostif
>   *  @hw: pointer to hardware structure
>   *  @offset: offset of  word in the EEPROM to write
>   *  @data: word write to the EEPROM
> @@ -2318,7 +2318,7 @@ static int
> ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,  }
> 
>  /**
> - * ixgbe_get_lasi_ext_t_x550em - Determime external Base T PHY
> interrupt cause
> + * ixgbe_get_lasi_ext_t_x550em - Determine external Base T PHY
> + interrupt cause
>   * @hw: pointer to hardware structure
>   * @lsc: pointer to boolean flag which indicates whether external
> Base T
>   *	 PHY interrupt is lsc
> @@ -2628,7 +2628,7 @@ static int
> ixgbe_ext_phy_t_x550em_get_link(struct ixgbe_hw *hw, bool *link_up)  }
> 
>  /** ixgbe_setup_internal_phy_t_x550em - Configure KR PHY to X557 link
> - *  @hw: point to hardware structure
> + *  @hw: pointer to hardware structure
>   *
>   *  Configures the link between the integrated KR PHY and the
> external X557 PHY
>   *  The driver will call this function when it gets a link status
> change @@ -2745,7 +2745,7 @@ static int ixgbe_led_off_t_x550em(struct
> ixgbe_hw *hw, u32 led_idx)
>  	if (led_idx >= IXGBE_X557_MAX_LED_INDEX)
>  		return -EINVAL;
> 
> -	/* To turn on the LED, set mode to ON. */
> +	/* To turn off the LED, set mode to OFF. */
>  	hw->phy.ops.read_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
>  			     MDIO_MMD_VEND1, &phy_data);
>  	phy_data &= ~IXGBE_X557_LED_MANUAL_SET_MASK; @@ -2812,7 +2812,7
> @@ int ixgbe_set_fw_drv_ver_x550(struct ixgbe_hw *hw, u8 maj, u8 min,
>  	return ret_val;
>  }
> 
> -/** ixgbe_get_lcd_x550em - Determine lowest common denominator
> +/** ixgbe_get_lcd_t_x550em - Determine lowest common denominator
>   *  @hw: pointer to hardware structure
>   *  @lcd_speed: pointer to lowest common link speed
>   *
> --
> 2.50.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>