netdev - Re: [PATCH net-next v4 4/5] bnxt_fwctl: Add bnxt fwctl device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv3jcQVycjf1=ds=Vb1phefdG8LcJUTC5BUJSo6kxwhRQg@mail.gmail.com>
Date: Thu, 2 Oct 2025 13:57:23 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Dave Jiang <dave.jiang@...el.com>
Cc: jgg@...pe.ca, michael.chan@...adcom.com, saeedm@...dia.com, 
	Jonathan.Cameron@...wei.com, davem@...emloft.net, corbet@....net, 
	edumazet@...gle.com, gospo@...adcom.com, kuba@...nel.org, 
	netdev@...r.kernel.org, pabeni@...hat.com, andrew+netdev@...n.ch, 
	selvin.xavier@...adcom.com, leon@...nel.org, 
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net-next v4 4/5] bnxt_fwctl: Add bnxt fwctl device

On Tue, Sep 30, 2025 at 12:04 AM Dave Jiang <dave.jiang@...el.com> wrote:
>
>
>
> On 9/27/25 2:39 AM, Pavan Chebbi wrote:
> > Create bnxt_fwctl device. This will bind to bnxt's aux device.
> > On the upper edge, it will register with the fwctl subsystem.
> > It will make use of bnxt's ULP functions to send FW commands.
> >
> > Also move 'bnxt_aux_priv' definition required by bnxt_fwctl
> > from bnxt.h to ulp.h.
> >
> > Reviewed-by: Andy Gospodarek <gospo@...adcom.com>
> > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
>
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>
> just a minor comment below

Thanks for the review, Dave. Yes, the DMA address holders can be
temporary variables.
I can make that change since I must spin a new revision anyway.

<-->
> I think these 2 don't need to be in bnxtctl_dev and can be temporary variables. Since they all get freed at the end of the function that uses it.
>
> DJ
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)