netdev - Re: [PATCH net-next v4 4/5] bnxt_fwctl: Add bnxt fwctl device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv1_gTr=ay0JcKwyVVoNUvFu_9CnT+D+tU+J20OoGUmN+w@mail.gmail.com>
Date: Thu, 2 Oct 2025 13:59:40 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: jgg@...pe.ca, michael.chan@...adcom.com, dave.jiang@...el.com, 
	saeedm@...dia.com, davem@...emloft.net, corbet@....net, edumazet@...gle.com, 
	gospo@...adcom.com, kuba@...nel.org, netdev@...r.kernel.org, 
	pabeni@...hat.com, andrew+netdev@...n.ch, selvin.xavier@...adcom.com, 
	leon@...nel.org, kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net-next v4 4/5] bnxt_fwctl: Add bnxt fwctl device

On Wed, Oct 1, 2025 at 8:33 PM Jonathan Cameron
<jonathan.cameron@...wei.com> wrote:
>
> On Sat, 27 Sep 2025 02:39:29 -0700
> Pavan Chebbi <pavan.chebbi@...adcom.com> wrote:
>
> > Create bnxt_fwctl device. This will bind to bnxt's aux device.
> > On the upper edge, it will register with the fwctl subsystem.
> > It will make use of bnxt's ULP functions to send FW commands.
> >
> > Also move 'bnxt_aux_priv' definition required by bnxt_fwctl
> > from bnxt.h to ulp.h.
> >
> > Reviewed-by: Andy Gospodarek <gospo@...adcom.com>
> > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
>
> A few minor things inline.
>
> J

Thanks Jonathan for the additional comments. I will address them in
the next revision after
net-next opens.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)