[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87o6qkcnol.fsf@nvidia.com>
Date: Mon, 6 Oct 2025 11:40:59 +0200
From: Petr Machata <petrm@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>, "Antonio
Quartulli" <antonio@...nvpn.net>, "Matthieu Baerts (NGI0)"
<matttbe@...nel.org>, Allison Henderson <allison.henderson@...cle.com>,
<shuah@...nel.org>, <jv@...sburgh.net>, <olteanv@...il.com>,
<jiri@...nulli.us>, <mst@...hat.com>, <jasowang@...hat.com>,
<xuanzhuo@...ux.alibaba.com>, <eperezma@...hat.com>, <kuniyu@...gle.com>,
<martineau@...nel.org>, <pablo@...filter.org>, <kadlec@...filter.org>,
<fw@...len.de>, <petrm@...dia.com>, <razor@...ckwall.org>,
<idosch@...dia.com>, <linux-kselftest@...r.kernel.org>,
<mptcp@...ts.linux.dev>, <netfilter-devel@...r.kernel.org>,
<coreteam@...filter.org>
Subject: Re: [PATCH net v2] selftests: net: unify the Makefile formats
Jakub Kicinski <kuba@...nel.org> writes:
> We get a significant number of conflicts between net and net-next
> because of selftests Makefile changes. People tend to append new
> test cases at the end of the Makefile when there's no clear sort
> order. Sort all networking selftests Makefiles, use the following
> format:
If we see weird errors in CI, it might be because tests now run in a
different order and previously masked missed cleanups are now exposed.
>
> VAR_NAME := \
> entry1 \
> entry2 \
> entry3 \
> # end of VAR_NAME
>
> Some Makefiles are already pretty close to this.
>
> Acked-by: Antonio Quartulli <antonio@...nvpn.net>
> Acked-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> Acked-by: Allison Henderson <allison.henderson@...cle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Petr Machata <petrm@...dia.com>
But there's a missed nit below.
> diff --git a/tools/testing/selftests/drivers/net/dsa/Makefile b/tools/testing/selftests/drivers/net/dsa/Makefile
> index cd6817fe5be6..699e3565d735 100644
> --- a/tools/testing/selftests/drivers/net/dsa/Makefile
> +++ b/tools/testing/selftests/drivers/net/dsa/Makefile
> @@ -9,11 +9,13 @@ TEST_PROGS = bridge_locked_port.sh \
This should have the header converted as well:
TEST_PROGS := \
bridge_locked_port.sh \
> local_termination.sh \
> no_forwarding.sh \
> tc_actions.sh \
> - test_bridge_fdb_stress.sh
> + test_bridge_fdb_stress.sh \
> +# end of TEST_PROGS
>
> TEST_FILES := \
> + forwarding.config \
> run_net_forwarding_test.sh \
> - forwarding.config
> +# end of TEST_FILES
>
> TEST_INCLUDES := \
> ../../../net/forwarding/bridge_locked_port.sh \
Powered by blists - more mailing lists