netdev - Re: [PATCH net v2] selftests: net: unify the Makefile formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251006103012.0493a4b4@kernel.org>
Date: Mon, 6 Oct 2025 10:30:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>, "Antonio
 Quartulli" <antonio@...nvpn.net>, "Matthieu Baerts (NGI0)"
 <matttbe@...nel.org>, Allison Henderson <allison.henderson@...cle.com>,
 <shuah@...nel.org>, <jv@...sburgh.net>, <olteanv@...il.com>,
 <jiri@...nulli.us>, <mst@...hat.com>, <jasowang@...hat.com>,
 <xuanzhuo@...ux.alibaba.com>, <eperezma@...hat.com>, <kuniyu@...gle.com>,
 <martineau@...nel.org>, <pablo@...filter.org>, <kadlec@...filter.org>,
 <fw@...len.de>, <razor@...ckwall.org>, <idosch@...dia.com>,
 <linux-kselftest@...r.kernel.org>, <mptcp@...ts.linux.dev>,
 <netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>
Subject: Re: [PATCH net v2] selftests: net: unify the Makefile formats

On Mon, 6 Oct 2025 11:40:59 +0200 Petr Machata wrote:
> > We get a significant number of conflicts between net and net-next
> > because of selftests Makefile changes. People tend to append new
> > test cases at the end of the Makefile when there's no clear sort
> > order. Sort all networking selftests Makefiles, use the following
> > format:  
> 
> If we see weird errors in CI, it might be because tests now run in a
> different order and previously masked missed cleanups are now exposed.

Yes, sorry. I enabled the check before merging this so there's probably
some transient false positives. Which is fine, the pw checks are for
maintainers? :)

> > diff --git a/tools/testing/selftests/drivers/net/dsa/Makefile b/tools/testing/selftests/drivers/net/dsa/Makefile
> > index cd6817fe5be6..699e3565d735 100644
> > --- a/tools/testing/selftests/drivers/net/dsa/Makefile
> > +++ b/tools/testing/selftests/drivers/net/dsa/Makefile
> > @@ -9,11 +9,13 @@ TEST_PROGS = bridge_locked_port.sh \  
> 
> This should have the header converted as well:
> 
> TEST_PROGS := \
> 	bridge_locked_port.sh \

Ack, let me fix when applying.