netdev - Re: [External] : [PATCH net-next v4 01/12] virtio_pci: Remove supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1720c75-3d56-4040-b7ac-97c399302257@oracle.com>
Date: Mon, 13 Oct 2025 22:08:02 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Daniel Jurgens <danielj@...dia.com>, netdev@...r.kernel.org,
        mst@...hat.com, jasowang@...hat.com, alex.williamson@...hat.com,
        pabeni@...hat.com
Cc: virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
        yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
        shameerali.kolothum.thodi@...wei.com, jgg@...pe.ca,
        kevin.tian@...el.com, kuba@...nel.org, andrew+netdev@...n.ch,
        edumazet@...gle.com
Subject: Re: [External] : [PATCH net-next v4 01/12] virtio_pci: Remove
 supported_cap size build assert



On 10/13/2025 8:57 PM, Daniel Jurgens wrote:
> The cap ID list can be more than 64 bits. Remove the build assert. Also
> remove caching of the supported caps, it wasn't used.
> 
> Signed-off-by: Daniel Jurgens <danielj@...dia.com>
> Reviewed-by: Parav Pandit <parav@...dia.com>
> 
> ---
> v4: New patch for V4
> ---
>   drivers/virtio/virtio_pci_common.h | 1 -
>   drivers/virtio/virtio_pci_modern.c | 7 +------
>   2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/virtio/virtio_pci_common.h b/drivers/virtio/virtio_pci_common.h
> index 8cd01de27baf..fc26e035e7a6 100644
> --- a/drivers/virtio/virtio_pci_common.h
> +++ b/drivers/virtio/virtio_pci_common.h
> @@ -48,7 +48,6 @@ struct virtio_pci_admin_vq {
>   	/* Protects virtqueue access. */
>   	spinlock_t lock;
>   	u64 supported_cmds;
> -	u64 supported_caps;
>   	u8 max_dev_parts_objects;
>   	struct ida dev_parts_ida;
>   	/* Name of the admin queue: avq.$vq_index. */
> diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
> index dd0e65f71d41..810f9f636b5e 100644
> --- a/drivers/virtio/virtio_pci_modern.c
> +++ b/drivers/virtio/virtio_pci_modern.c
> @@ -323,12 +323,7 @@ static void virtio_pci_admin_cmd_cap_init(struct virtio_device *virtio_dev)
>   	if (ret)
>   		goto end;
>   
> -	/* Max number of caps fits into a single u64 */
> -	BUILD_BUG_ON(sizeof(data->supported_caps) > sizeof(u64));
> -
> -	vp_dev->admin_vq.supported_caps = le64_to_cpu(data->supported_caps[0]);
> -
> -	if (!(vp_dev->admin_vq.supported_caps & (1 << VIRTIO_DEV_PARTS_CAP)))
> +	if (!(le64_to_cpu(data->support_caps[0]) & (1 << VIRTIO_DEV_PARTS_CAP)))

typo support_caps -> supported_caps ?

>   		goto end;
>   
>   	virtio_pci_admin_cmd_dev_parts_objects_enable(virtio_dev);

Thanks,
Alok