netdev - Re: [External] : [PATCH net-next v4 01/12] virtio_pci: Remove supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3530d46e-68c5-4966-923e-943da2f45fbd@nvidia.com>
Date: Mon, 13 Oct 2025 12:57:03 -0500
From: Dan Jurgens <danielj@...dia.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, netdev@...r.kernel.org,
 mst@...hat.com, jasowang@...hat.com, alex.williamson@...hat.com,
 pabeni@...hat.com
Cc: virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 shameerali.kolothum.thodi@...wei.com, jgg@...pe.ca, kevin.tian@...el.com,
 kuba@...nel.org, andrew+netdev@...n.ch, edumazet@...gle.com
Subject: Re: [External] : [PATCH net-next v4 01/12] virtio_pci: Remove
 supported_cap size build assert

On 10/13/25 11:38 AM, ALOK TIWARI wrote:
> 
> 
> On 10/13/2025 8:57 PM, Daniel Jurgens wrote:
>> The cap ID list can be more than 64 bits. Remove the build assert. Also
>> remove caching of the supported caps, it wasn't used.
>> -    if (!(vp_dev->admin_vq.supported_caps & (1 <<
>> VIRTIO_DEV_PARTS_CAP)))
>> +    if (!(le64_to_cpu(data->support_caps[0]) & (1 <<
>> VIRTIO_DEV_PARTS_CAP)))
> 
> typo support_caps -> supported_caps ?
> 

Thanks Alok, I dropped a patch before submitting that fixed this
problem, not that it could have been left this way anyway.

I've added this, and the comments on 0004 for v5.