| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202510141339.ne1O8cPc-lkp@intel.com>
Date: Tue, 14 Oct 2025 13:28:10 +0800
From: kernel test robot <lkp@...el.com>
To: Daniel Jurgens <danielj@...dia.com>, netdev@...r.kernel.org,
mst@...hat.com, jasowang@...hat.com, alex.williamson@...hat.com,
pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, virtualization@...ts.linux.dev,
parav@...dia.com, shshitrit@...dia.com, yohadt@...dia.com,
xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
shameerali.kolothum.thodi@...wei.com, jgg@...pe.ca,
kevin.tian@...el.com, kuba@...nel.org, andrew+netdev@...n.ch,
edumazet@...gle.com, Daniel Jurgens <danielj@...dia.com>
Subject: Re: [PATCH net-next v4 01/12] virtio_pci: Remove supported_cap size
build assert
Hi Daniel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Jurgens/virtio_pci-Remove-supported_cap-size-build-assert/20251014-004146
base: net-next/main
patch link: https://lore.kernel.org/r/20251013152742.619423-2-danielj%40nvidia.com
patch subject: [PATCH net-next v4 01/12] virtio_pci: Remove supported_cap size build assert
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20251014/202510141339.ne1O8cPc-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251014/202510141339.ne1O8cPc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510141339.ne1O8cPc-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/byteorder/little_endian.h:5,
from arch/x86/include/uapi/asm/byteorder.h:5,
from include/asm-generic/qrwlock_types.h:6,
from arch/x86/include/asm/spinlock_types.h:7,
from include/linux/spinlock_types_raw.h:7,
from include/linux/ratelimit_types.h:7,
from include/linux/printk.h:9,
from include/asm-generic/bug.h:22,
from arch/x86/include/asm/bug.h:103,
from arch/x86/include/asm/alternative.h:9,
from arch/x86/include/asm/segment.h:6,
from arch/x86/include/asm/ptrace.h:5,
from arch/x86/include/asm/math_emu.h:5,
from arch/x86/include/asm/processor.h:13,
from include/linux/sched.h:13,
from include/linux/delay.h:13,
from drivers/virtio/virtio_pci_modern.c:17:
drivers/virtio/virtio_pci_modern.c: In function 'virtio_pci_admin_cmd_cap_init':
drivers/virtio/virtio_pci_modern.c:326:33: error: 'struct virtio_admin_cmd_query_cap_id_result' has no member named 'support_caps'; did you mean 'supported_caps'?
326 | if (!(le64_to_cpu(data->support_caps[0]) & (1 << VIRTIO_DEV_PARTS_CAP)))
| ^~~~~~~~~~~~
include/uapi/linux/byteorder/little_endian.h:33:51: note: in definition of macro '__le64_to_cpu'
33 | #define __le64_to_cpu(x) ((__force __u64)(__le64)(x))
| ^
drivers/virtio/virtio_pci_modern.c:326:15: note: in expansion of macro 'le64_to_cpu'
326 | if (!(le64_to_cpu(data->support_caps[0]) & (1 << VIRTIO_DEV_PARTS_CAP)))
| ^~~~~~~~~~~
>> drivers/virtio/virtio_pci_modern.c:307:35: warning: unused variable 'vp_dev' [-Wunused-variable]
307 | struct virtio_pci_device *vp_dev = to_vp_device(virtio_dev);
| ^~~~~~
vim +/vp_dev +307 drivers/virtio/virtio_pci_modern.c
bfcad518605d92 Yishai Hadas 2024-11-13 304
bfcad518605d92 Yishai Hadas 2024-11-13 305 static void virtio_pci_admin_cmd_cap_init(struct virtio_device *virtio_dev)
bfcad518605d92 Yishai Hadas 2024-11-13 306 {
bfcad518605d92 Yishai Hadas 2024-11-13 @307 struct virtio_pci_device *vp_dev = to_vp_device(virtio_dev);
bfcad518605d92 Yishai Hadas 2024-11-13 308 struct virtio_admin_cmd_query_cap_id_result *data;
bfcad518605d92 Yishai Hadas 2024-11-13 309 struct virtio_admin_cmd cmd = {};
bfcad518605d92 Yishai Hadas 2024-11-13 310 struct scatterlist result_sg;
bfcad518605d92 Yishai Hadas 2024-11-13 311 int ret;
bfcad518605d92 Yishai Hadas 2024-11-13 312
bfcad518605d92 Yishai Hadas 2024-11-13 313 data = kzalloc(sizeof(*data), GFP_KERNEL);
bfcad518605d92 Yishai Hadas 2024-11-13 314 if (!data)
bfcad518605d92 Yishai Hadas 2024-11-13 315 return;
bfcad518605d92 Yishai Hadas 2024-11-13 316
bfcad518605d92 Yishai Hadas 2024-11-13 317 sg_init_one(&result_sg, data, sizeof(*data));
bfcad518605d92 Yishai Hadas 2024-11-13 318 cmd.opcode = cpu_to_le16(VIRTIO_ADMIN_CMD_CAP_ID_LIST_QUERY);
16c22c56d42825 Daniel Jurgens 2025-03-04 319 cmd.group_type = cpu_to_le16(VIRTIO_ADMIN_GROUP_TYPE_SELF);
bfcad518605d92 Yishai Hadas 2024-11-13 320 cmd.result_sg = &result_sg;
bfcad518605d92 Yishai Hadas 2024-11-13 321
bfcad518605d92 Yishai Hadas 2024-11-13 322 ret = vp_modern_admin_cmd_exec(virtio_dev, &cmd);
bfcad518605d92 Yishai Hadas 2024-11-13 323 if (ret)
bfcad518605d92 Yishai Hadas 2024-11-13 324 goto end;
bfcad518605d92 Yishai Hadas 2024-11-13 325
c1e3216169ec0d Daniel Jurgens 2025-10-13 @326 if (!(le64_to_cpu(data->support_caps[0]) & (1 << VIRTIO_DEV_PARTS_CAP)))
bfcad518605d92 Yishai Hadas 2024-11-13 327 goto end;
bfcad518605d92 Yishai Hadas 2024-11-13 328
bfcad518605d92 Yishai Hadas 2024-11-13 329 virtio_pci_admin_cmd_dev_parts_objects_enable(virtio_dev);
bfcad518605d92 Yishai Hadas 2024-11-13 330 end:
bfcad518605d92 Yishai Hadas 2024-11-13 331 kfree(data);
bfcad518605d92 Yishai Hadas 2024-11-13 332 }
bfcad518605d92 Yishai Hadas 2024-11-13 333
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists