netdev - Re: [PATCH net-next v5] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8936e7e-da32-4562-a88e-af5d763a883e@lunn.ch>
Date: Tue, 14 Oct 2025 14:43:01 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Wen Gu <guwen@...ux.alibaba.com>,
	Philo Lu <lulie@...ux.alibaba.com>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Vivian Wang <wangruikang@...as.ac.cn>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
	Dust Li <dust.li@...ux.alibaba.com>, alok.a.tiwari@...cle.com,
	kalesh-anakkur.purayil@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5] eea: Add basic driver framework for Alibaba
 Elastic Ethernet Adaptor

> > That also means that you require the reviewers to invest a lot of extra
> > effort here, which in turn does not help making progresses.
> 
> Indeed, it's been quite a while, but I haven't made any substantial progress on
> this patchset, and I'm really considering this. Would splitting up a few commits
> speed up the review process?

Flip the question around, say you where asked to review this work
mixed in with all your other work. Would you not find it easier to
review 15 small patches, one per coffee break, after lunch, before
setting off home, waiting for a kernel to compile, etc, than one huge
patch.

Also, good subject lines attacks reviews who have interests in
subsections. If the subject line says ethtool, i'm more likely to look
at that one patch, and you will get a review of it. When ethtool is
not obvious, i probably won't bother.

	Andrew