netdev - Re: [PATCH net-next 1/2] net: fbnic: Fix page chunking logic when PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO5FwdsNaO_H7s8i@horms.kernel.org>
Date: Tue, 14 Oct 2025 13:44:49 +0100
From: Simon Horman <horms@...nel.org>
To: Dimitri Daskalakis <dimitri.daskalakis1@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Alexander Duyck <alexanderduyck@...com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: fbnic: Fix page chunking logic when
 PAGE_SIZE > 4K

On Mon, Oct 13, 2025 at 02:14:48PM -0700, Dimitri Daskalakis wrote:
> The HW always works on a 4K page size. When the OS supports larger
> pages, we fragment them across multiple BDQ descriptors.
> We were not properly incrementing the descriptor, which resulted in us
> specifying the last chunks id/addr and then 15 zero descriptors. This
> would cause packet loss and driver crashes. This is not a fix since the
> Kconfig prevents use outside of x86.
> 
> Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>