netdev - Re: [PATCH net v2 0/3] fixes two virtio-net related bugs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1760410511.4877663-1-xuanzhuo@linux.alibaba.com>
Date: Tue, 14 Oct 2025 10:55:11 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: netdev@...r.kernel.org,
 Jason Wang <jasowang@...hat.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Willem de Bruijn <willemb@...gle.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Alvaro Karsz <alvaro.karsz@...id-run.com>,
 Heng Qi <hengqi@...ux.alibaba.com>,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH net v2 0/3] fixes two virtio-net related bugs.

On Mon, 13 Oct 2025 03:56:35 -0400, "Michael S. Tsirkin" <mst@...hat.com> wrote:
> On Mon, Oct 13, 2025 at 10:06:26AM +0800, Xuan Zhuo wrote:
> > As discussed in http://lore.kernel.org/all/20250919013450.111424-1-xuanzhuo@linux.alibaba.com
> > Commit #1 Move the flags into the existing if condition; the issue is that it introduces a
> > small amount of code duplication.
>
>
> How were commits 1 and 2 tested?

These two are not troublesome. I tested #1 in big mode. #2 has no special
requirements. I tested it on qemu and observed the hdr len.

Thanks.

>
>
> > Commit #3 is new to fix the hdr len in tunnel gso feature.
> >
> > Hi @Paolo Abenchi,
> > Could you please test commit #3? I don't have a suitable test environment, as
> > QEMU doesn't currently support the tunnel GSO feature.
> >
> > Thanks.
>
>
> AFAIK host_tunnel and guest_tunnel flags enable exactly that.
>
>
> > Xuan Zhuo (3):
> >   virtio-net: fix incorrect flags recording in big mode
> >   virtio-net: correct hdr_len handling for VIRTIO_NET_F_GUEST_HDRLEN
> >   virtio-net: correct hdr_len handling for tunnel gso
> >
> >  drivers/net/virtio_net.c   | 16 ++++++++-----
> >  include/linux/virtio_net.h | 46 ++++++++++++++++++++++++++++++++------
> >  2 files changed, 50 insertions(+), 12 deletions(-)
> >
> > --
> > 2.32.0.3.g01195cf9f
>