netdev - Re: [PATCH net-next 10/14] ionic: convert to ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6641d925-b953-46b3-9e45-2284d5e2e8ad@amd.com>
Date: Fri, 17 Oct 2025 10:11:50 -0700
From: Brett Creeley <bcreeley@....com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Igor Russkikh <irusskikh@...vell.com>, Egor Pomozov <epomozov@...vell.com>,
 Potnuri Bharat Teja <bharat@...lsio.com>,
 Dimitris Michailidis <dmichail@...gible.com>,
 Jian Shen <shenjian15@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
 Jijie Shao <shaojijie@...wei.com>, Sunil Goutham <sgoutham@...vell.com>,
 Geetha sowjanya <gakula@...vell.com>, Subbaraya Sundeep
 <sbhatta@...vell.com>, Bharat Bhushan <bbhushan2@...vell.com>,
 Tariq Toukan <tariqt@...dia.com>, Brett Creeley <brett.creeley@....com>,
 Niklas Söderlund <niklas.soderlund@...natech.se>,
 Paul Barker <paul@...rker.dev>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
 MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>
Cc: Richard Cochran <richardcochran@...il.com>,
 Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net-next 10/14] ionic: convert to ndo_hwtstamp API

On 10/13/2025 9:37 AM, Vadim Fedorenko wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Convert driver to use .ndo_hwtstamp_get()/.ndo_hwtstamp_set() callbacks.
> ionic_eth_ioctl() becomes empty, remove it.
> 
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> ---
>   .../net/ethernet/pensando/ionic/ionic_lif.c   | 17 +-----
>   .../net/ethernet/pensando/ionic/ionic_lif.h   | 11 ++--
>   .../net/ethernet/pensando/ionic/ionic_phc.c   | 59 +++++++++++--------
>   3 files changed, 45 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index b28966ae50c2..c5f2231a888f 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -2335,20 +2335,6 @@ static int ionic_stop(struct net_device *netdev)
>          return 0;
>   }
> 
> -static int ionic_eth_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
> -{
> -       struct ionic_lif *lif = netdev_priv(netdev);
> -
> -       switch (cmd) {
> -       case SIOCSHWTSTAMP:
> -               return ionic_lif_hwstamp_set(lif, ifr);
> -       case SIOCGHWTSTAMP:
> -               return ionic_lif_hwstamp_get(lif, ifr);
> -       default:
> -               return -EOPNOTSUPP;
> -       }
> -}
> -
>   static int ionic_get_vf_config(struct net_device *netdev,
>                                 int vf, struct ifla_vf_info *ivf)
>   {
> @@ -2812,7 +2798,6 @@ static int ionic_xdp(struct net_device *netdev, struct netdev_bpf *bpf)
>   static const struct net_device_ops ionic_netdev_ops = {
>          .ndo_open               = ionic_open,
>          .ndo_stop               = ionic_stop,
> -       .ndo_eth_ioctl          = ionic_eth_ioctl,
>          .ndo_start_xmit         = ionic_start_xmit,
>          .ndo_bpf                = ionic_xdp,
>          .ndo_xdp_xmit           = ionic_xdp_xmit,
> @@ -2833,6 +2818,8 @@ static const struct net_device_ops ionic_netdev_ops = {
>          .ndo_get_vf_config      = ionic_get_vf_config,
>          .ndo_set_vf_link_state  = ionic_set_vf_link_state,
>          .ndo_get_vf_stats       = ionic_get_vf_stats,
> +       .ndo_hwtstamp_get       = ionic_lif_hwstamp_get,
> +       .ndo_hwtstamp_set       = ionic_lif_hwstamp_set,

Nit, but if you are changing this and you have to re-spin the series it 
would align with the other ndo callbacks to rename these by removing the 
"_lif_" portion of the name:

   ionic_hwstamp_get
   ionic_hwstamp_set

Other than that LGTM.

Reviewed-by: Brett Creeley <brett.creeley@....com>