netdev - Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63b2056f-3d5a-4fca-8600-526619c33647@rootcommit.com>
Date: Fri, 17 Oct 2025 15:53:44 +0000 (UTC)
From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
To: Emil Renner Berthing <emil.renner.berthing@...il.com>
Cc: michael.opdenacker@...tcommit.com, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Yixun Lan <dlan@...too.org>, netdev@...r.kernel.org,
 linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by
 default

Hi Emil

Thanks for the review!

On 10/17/25 17:33, Emil Renner Berthing wrote:
> On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@...tcommit.com> wrote:
>> From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
>>
>> Supports booting boards on NFS filesystems, without going
>> through an initramfs.
> Please don't do this. If we build in every ethernet driver that might
> be used to boot from NFS we'll end up with almost every driver
> built-in and huge kernels. If you need this there is nothing
> preventing you from building the driver in, but please don't bloat
> defconfig kernels for everyone else.

Understood. You have a point. It's not really a problem to customize 
kernel configuration for each board as you said.
So, please forget this particular patch :)
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com