netdev - Re: [PATCH net-next 1/2] net: phy: micrel: simplify return in ksz9477_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a2e251-e0ad-431c-bc08-1c464d2868c0@lunn.ch>
Date: Fri, 17 Oct 2025 22:42:12 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: hkallweit1@...il.com, kuba@...nel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	horms@...nel.org, linux@...linux.org.uk, netdev@...r.kernel.org,
	alok.a.tiwarilinux@...il.com
Subject: Re: [PATCH net-next 1/2] net: phy: micrel: simplify return in
 ksz9477_phy_errata()

On Fri, Oct 17, 2025 at 12:35:20PM -0700, Alok Tiwari wrote:
> ksz9477_phy_errata function currently assigns the return value of
> genphy_restart_aneg() to a variable and then immediately returns it
> 
>     err = genphy_restart_aneg(phydev);
>     if (err)
>         return err;
> 
>     return err;
> 
> This can be simplified by directly returning the function call
> result, as the intermediate variable and conditional are redundant.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew