netdev - Re: [PATCH net-next 2/4] net: fec: use new iterator phy_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e96d5ce-ef8f-4200-bad7-09618cac8f28@engleder-embedded.com>
Date: Fri, 17 Oct 2025 22:51:29 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, imx@...ts.linux.dev,
 linux-omap@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
 Clark Wang <xiaoning.wang@....com>, Siddharth Vadapalli
 <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net-next 2/4] net: fec: use new iterator phy_for_each

On 17.10.25 22:41, Heiner Kallweit wrote:
> Use new iterator phy_for_each() to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>   drivers/net/ethernet/freescale/fec_main.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 1edcfaee6..d7c39ef2d 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2552,7 +2552,6 @@ static int fec_enet_mii_init(struct platform_device *pdev)
>   	int err = -ENXIO;
>   	u32 mii_speed, holdtime;
>   	u32 bus_freq;
> -	int addr;
>   
>   	/*
>   	 * The i.MX28 dual fec interfaces are not equal.
> @@ -2667,11 +2666,8 @@ static int fec_enet_mii_init(struct platform_device *pdev)
>   	of_node_put(node);
>   
>   	/* find all the PHY devices on the bus and set mac_managed_pm to true */
> -	for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> -		phydev = mdiobus_get_phy(fep->mii_bus, addr);
> -		if (phydev)
> -			phydev->mac_managed_pm = true;
> -	}
> +	phy_for_each(fep->mii_bus, phydev)
> +		phydev->mac_managed_pm = true;
>   
>   	mii_cnt++;
>   

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>