netdev - Re: [PATCH net-next 3/4] net: davinci_mdio: use new iterator phy_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21605393-1cdd-48ea-8da7-a43c5e354005@engleder-embedded.com>
Date: Fri, 17 Oct 2025 22:51:59 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, imx@...ts.linux.dev,
 linux-omap@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
 Clark Wang <xiaoning.wang@....com>, Siddharth Vadapalli
 <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net-next 3/4] net: davinci_mdio: use new iterator
 phy_for_each

On 17.10.25 22:42, Heiner Kallweit wrote:
> Use new iterator phy_for_each() to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>   drivers/net/ethernet/ti/davinci_mdio.c | 14 +++++---------
>   1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 68507126b..5a7ed5ebf 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> @@ -548,8 +548,8 @@ static int davinci_mdio_probe(struct platform_device *pdev)
>   	struct davinci_mdio_data *data;
>   	struct resource *res;
>   	struct phy_device *phy;
> -	int ret, addr;
>   	int autosuspend_delay_ms = -1;
> +	int ret;
>   
>   	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>   	if (!data)
> @@ -652,14 +652,10 @@ static int davinci_mdio_probe(struct platform_device *pdev)
>   		goto bail_out;
>   
>   	/* scan and dump the bus */
> -	for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> -		phy = mdiobus_get_phy(data->bus, addr);
> -		if (phy) {
> -			dev_info(dev, "phy[%d]: device %s, driver %s\n",
> -				 phy->mdio.addr, phydev_name(phy),
> -				 phy->drv ? phy->drv->name : "unknown");
> -		}
> -	}
> +	phy_for_each(data->bus, phy)
> +		dev_info(dev, "phy[%d]: device %s, driver %s\n",
> +			 phy->mdio.addr, phydev_name(phy),
> +			 phy->drv ? phy->drv->name : "unknown");
>   
>   	return 0;
>   

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>