netdev - Re: [PATCH net-next 4/4] net: phy: use new iterator phy_for_each in mdiobus_prevent_c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a220296-9bc2-4db0-b3cc-f6365d6caa51@engleder-embedded.com>
Date: Fri, 17 Oct 2025 22:52:26 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, imx@...ts.linux.dev,
 linux-omap@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
 Clark Wang <xiaoning.wang@....com>, Siddharth Vadapalli
 <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net-next 4/4] net: phy: use new iterator phy_for_each in
 mdiobus_prevent_c45_scan

On 17.10.25 22:43, Heiner Kallweit wrote:
> Use new iterator phy_for_each() to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>   drivers/net/phy/mdio_bus_provider.c | 13 ++++---------
>   1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/phy/mdio_bus_provider.c b/drivers/net/phy/mdio_bus_provider.c
> index a2391d4b7..20792480d 100644
> --- a/drivers/net/phy/mdio_bus_provider.c
> +++ b/drivers/net/phy/mdio_bus_provider.c
> @@ -249,20 +249,15 @@ static int mdiobus_scan_bus_c45(struct mii_bus *bus)
>    */
>   static bool mdiobus_prevent_c45_scan(struct mii_bus *bus)
>   {
> -	int i;
> +	struct phy_device *phydev;
>   
> -	for (i = 0; i < PHY_MAX_ADDR; i++) {
> -		struct phy_device *phydev;
> -		u32 oui;
> -
> -		phydev = mdiobus_get_phy(bus, i);
> -		if (!phydev)
> -			continue;
> -		oui = phydev->phy_id >> 10;
> +	phy_for_each(bus, phydev) {
> +		u32 oui = phydev->phy_id >> 10;
>   
>   		if (oui == MICREL_OUI)
>   			return true;
>   	}
> +
>   	return false;
>   }
>   

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>