netdev - Re: [PATCH net v3 3/3] ovpn: use datagram_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPjnm7PM_yWsnn2A@krikkit>
Date: Wed, 22 Oct 2025 16:18:03 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Ralf Lici <ralf@...delbit.com>
Cc: netdev@...r.kernel.org, Antonio Quartulli <antonio@...nvpn.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v3 3/3] ovpn: use datagram_poll_queue for socket
 readiness in TCP

2025-10-21, 12:09:42 +0200, Ralf Lici wrote:
> openvpn TCP encapsulation uses a custom queue to deliver packets to
> userspace. Currently it relies on datagram_poll, which checks
> sk_receive_queue, leading to false readiness signals when that queue
> contains non-userspace packets.
> 
> Switch ovpn_tcp_poll to use datagram_poll_queue with the peer's
> user_queue, ensuring poll only signals readiness when userspace data is
> actually available. Also refactor ovpn_tcp_poll in order to enforce the
> assumption we can make on the lifetime of ovpn_sock and peer.
> 
> Fixes: 11851cbd60ea ("ovpn: implement TCP transport")
> Signed-off-by: Antonio Quartulli <antonio@...nvpn.net>
> Signed-off-by: Ralf Lici <ralf@...delbit.com>
> ---
>  drivers/net/ovpn/tcp.c | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks Ralf.

-- 
Sabrina