netdev - Re: [PATCH net v3 2/3] espintcp: use datagram_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPjmfMRSRielEIYK@krikkit>
Date: Wed, 22 Oct 2025 16:13:16 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Ralf Lici <ralf@...delbit.com>
Cc: netdev@...r.kernel.org, Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Antonio Quartulli <antonio@...nvpn.net>
Subject: Re: [PATCH net v3 2/3] espintcp: use datagram_poll_queue for socket
 readiness

2025-10-21, 12:09:41 +0200, Ralf Lici wrote:
> espintcp uses a custom queue (ike_queue) to deliver packets to
> userspace. The polling logic relies on datagram_poll, which checks
> sk_receive_queue, which can lead to false readiness signals when that
> queue contains non-userspace packets.
> 
> Switch espintcp_poll to use datagram_poll_queue with ike_queue, ensuring
> poll only signals readiness when userspace data is actually available.
> 
> Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)")
> Signed-off-by: Ralf Lici <ralf@...delbit.com>
> ---
>  net/xfrm/espintcp.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina