netdev - Re: [PATCH net-next 3/6] net: phylink: add phylink managed MAC Wake-on-Lan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPkhHIMJAYNEj_6Z@shell.armlinux.org.uk>
Date: Wed, 22 Oct 2025 19:23:24 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-stm32@...md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/6] net: phylink: add phylink managed MAC
 Wake-on-Lan support

On Wed, Oct 22, 2025 at 04:06:00PM +0200, Maxime Chevallier wrote:
> >  int phylink_ethtool_set_wol(struct phylink *pl, struct ethtool_wolinfo *wol)
> >  {
> > +	struct ethtool_wolinfo w;

...

> > +			phy_ethtool_get_wol(pl->phydev, &w);
> > +
> > +			/* Any Wake-on-Lan modes which the PHY is handling
> > +			 * should not be passed on to the MAC.
> > +			 */
> > +			wolopts &= ~w.wolopts;
> 
> When PHY drivers gets converted to the new model, we'll have to look at
> how the .get_wol() behave WRT how they fill-in their wolopts.
> 
> The Broadcom driver for example may not set w.wolopts to 0 :
> 
>   https://elixir.bootlin.com/linux/v6.17.4/source/drivers/net/phy/broadcom.c#L1121
> 
> You'd probably end-up with garbage here then. But not blocking for your series.

Good point. We should initialise 'w' in the same way other users do, so:

+       struct ethtool_wolinfo w = { .cmd = ETHTOOL_GWOL };

Does your r-b still stand with this change?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!