netdev - Re: [PATCH v2 1/4] net: ravb: Make DBAT entry count configurable per-SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8uMpr+-F6gQZ+y6wrSUfV5BXV_xDaZcLVnwdpiw8g5W5A@mail.gmail.com>
Date: Thu, 23 Oct 2025 11:51:14 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Niklas Söderlund <niklas.soderlund@...natech.se>, 
	Paul Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>, netdev@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, stable@...r.kernel.org, 
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Subject: Re: [PATCH v2 1/4] net: ravb: Make DBAT entry count configurable per-SoC

Hi Jakub,

Thank you for the review.

On Thu, Oct 23, 2025 at 2:13 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 17 Oct 2025 16:18:27 +0100 Prabhakar wrote:
> > The number of CDARq (Current Descriptor Address Register) registers is not
> > fixed to 22 across all SoC variants. For example, the GBETH implementation
> > uses only two entries. Hardcoding the value leads to incorrect resource
> > allocation on such platforms.
>
> What is the user-visible problem? "Incorrect resource allocation" could
> mean anything from slight waste of system memory to the device falling
> over.
>
> If it's the former this is not a fix..
>
Ok, I'll drop the fixes and cc to stable and send it for net-next.

Cheers,
Prabhakar