netdev - Re: [PATCH net-next 2/2] dibs: Use subsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00eb725b-1e0a-47ec-9352-72c2623f6ab9@intel.com>
Date: Thu, 23 Oct 2025 17:18:10 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Alexandra Winter <wintera@...ux.ibm.com>
CC: Julian Ruess <julianr@...ux.ibm.com>, Mete Durlu <meted@...ux.ibm.com>,
	"D. Wythe" <alibuda@...ux.alibaba.com>, Dust Li <dust.li@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>, Wenjia Zhang
	<wenjia@...ux.ibm.com>, David Miller <davem@...emloft.net>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet
	<edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, Mahanta Jambigi
	<mjambigi@...ux.ibm.com>, Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu
	<guwen@...ux.alibaba.com>, <linux-rdma@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-s390@...r.kernel.org>, Heiko Carstens
	<hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
	<agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next 2/2] dibs: Use subsys_initcall()

From: Alexandra Winter <wintera@...ux.ibm.com>
Date: Thu, 23 Oct 2025 17:06:36 +0200

> In the case of built-in modules, the order of module_init() calls are
> derived from the Makefiles.
> 
> Use subsys_initcall() for the dibs module, to make sure dibs_init() is
> executed before dibs clients like smc and dibs devices like ism are
> initialized. So future dibs client or dibs device modules can use
> module_init() without the risk of getting the order in the Makefiles wrong.
> 
> Reported-by: Mete Durlu <meted@...ux.ibm.com>

Was this reported on LKML, so that you could add a 'Closes:' tag with
the link here or the report was internal?

> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>

Either way,

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
>  drivers/dibs/dibs_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index b015578b4d2e..dac14d843af7 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -271,5 +271,5 @@ static void __exit dibs_exit(void)
>  	class_destroy(dibs_class);
>  }
>  
> -module_init(dibs_init);
> +subsys_initcall(dibs_init);
>  module_exit(dibs_exit);

Thanks,
Olek