netdev - Re: [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPrj2FCKi5NGPF8u@linux.alibaba.com>
Date: Fri, 24 Oct 2025 10:26:32 +0800
From: Dust Li <dust.li@...ux.alibaba.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
	Julian Ruess <julianr@...ux.ibm.com>,
	Mete Durlu <meted@...ux.ibm.com>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>
Cc: Mahanta Jambigi <mjambigi@...ux.ibm.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>, linux-rdma@...r.kernel.org,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next 1/2] dibs: Remove reset of static vars in
 dibs_init()

On 2025-10-23 17:06:35, Alexandra Winter wrote:
>'clients' and 'max_client' are static variables and therefore don't need to
>be initialized.
>
>Reported-by: Mete Durlu <meted@...ux.ibm.com>
>Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>

Reviewed-by: Dust Li <dust.li@...ux.alibaba.com>

Best regards,
Dust

>---
> drivers/dibs/dibs_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
>index 0374f8350ff7..b015578b4d2e 100644
>--- a/drivers/dibs/dibs_main.c
>+++ b/drivers/dibs/dibs_main.c
>@@ -254,9 +254,6 @@ static int __init dibs_init(void)
> {
> 	int rc;
> 
>-	memset(clients, 0, sizeof(clients));
>-	max_client = 0;
>-
> 	dibs_class = class_create("dibs");
> 	if (IS_ERR(dibs_class))
> 		return PTR_ERR(dibs_class);
>-- 
>2.48.1