netdev - Re: [PATH net 1/2] net: ip: add drop reasons when handling ip fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cdfcd5a-3100-4ada-844c-beec0ac77de2@chinatelecom.cn>
Date: Fri, 24 Oct 2025 17:56:05 +0800
From: YonglongLi <liyonglong@...natelecom.cn>
To: Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATH net 1/2] net: ip: add drop reasons when handling ip
 fragments


On 10/24/2025 14:43,  Eric Dumazet wrote:
> On Thu, Oct 23, 2025 at 11:23 PM Yonglong Li <liyonglong@...natelecom.cn> wrote:
> 
>>                 return -EMSGSIZE;
>>         }
>>
>> @@ -871,7 +871,7 @@ int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
>>                         return 0;
>>                 }
>>
>> -               kfree_skb_list(iter.frag);
>> +               kfree_skb_list_reason(iter.frag, SKB_DROP_REASON_FRAG_FAILED);
>>
>>                 IP_INC_STATS(net, IPSTATS_MIB_FRAGFAILS);
>>                 return err;
>> @@ -923,7 +923,7 @@ int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
>>         return err;
>>
>>  fail:
>> -       kfree_skb(skb);
>> +       kfree_skb_reason(skb, SKB_DROP_REASON_FRAG_FAILED);
> 
> There are many different reasons for the possible failures ?
> skb_checksum_help() error,
> ip_frag_next() error
> output() error.
> 
> I think that having the distinction could really help, especially the
> output() one..

Hi Eric,

Thank you for for the suggestion. I will send a v2 with these case.

-- 
Li YongLong