netdev - Re: [PATH net 1/2] net: ip: add drop reasons when handling ip fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPuh49HWMxXNxsyM@horms.kernel.org>
Date: Fri, 24 Oct 2025 16:57:23 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Yonglong Li <liyonglong@...natelecom.cn>, netdev@...r.kernel.org,
	davem@...emloft.net, dsahern@...nel.org, pabeni@...hat.com,
	kuba@...nel.org
Subject: Re: [PATH net 1/2] net: ip: add drop reasons when handling ip
 fragments

On Thu, Oct 23, 2025 at 11:43:25PM -0700, Eric Dumazet wrote:
> On Thu, Oct 23, 2025 at 11:23 PM Yonglong Li <liyonglong@...natelecom.cn> wrote:
> >
> > 1, add new drop reason FRAG_FAILED, and use it in ip_do_fragment
> > 2, use drop reasons PKT_TOO_BIG in ip_fragment
> >
> > Signed-off-by: Yonglong Li <liyonglong@...natelecom.cn>
> > ---
> >  include/net/dropreason-core.h | 3 +++
> >  net/ipv4/ip_output.c          | 6 +++---
> >  2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/net/dropreason-core.h b/include/net/dropreason-core.h
> > index 58d91cc..7da80f4 100644
> > --- a/include/net/dropreason-core.h
> > +++ b/include/net/dropreason-core.h
> > @@ -99,6 +99,7 @@
> >         FN(DUP_FRAG)                    \
> >         FN(FRAG_REASM_TIMEOUT)          \
> >         FN(FRAG_TOO_FAR)                \
> > +       FN(FRAG_FAILED)                 \
> >         FN(TCP_MINTTL)                  \
> >         FN(IPV6_BAD_EXTHDR)             \
> >         FN(IPV6_NDISC_FRAG)             \
> > @@ -500,6 +501,8 @@ enum skb_drop_reason {
> >          * (/proc/sys/net/ipv4/ipfrag_max_dist)
> >          */
> >         SKB_DROP_REASON_FRAG_TOO_FAR,
> > +       /* do ip/ip6 fragment failed */

nit; This comment should be a Kernel doc, like the comments
     for other members of this enum.

> > +       SKB_DROP_REASON_FRAG_FAILED,
> >         /**
> >          * @SKB_DROP_REASON_TCP_MINTTL: ipv4 ttl or ipv6 hoplimit below
> >          * the threshold (IP_MINTTL or IPV6_MINHOPCOUNT).

...