netdev - Re: [PATCH v1 net-next 1/5] neighbour: Use RCU list helpers for neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKRwd3_2AcD3bR47VmgqQObc2y_7Z4OimDRMw05d4MLww@mail.gmail.com>
Date: Fri, 24 Oct 2025 05:31:49 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 1/5] neighbour: Use RCU list helpers for
 neigh_parms.list writers.

On Tue, Oct 21, 2025 at 10:40 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> We will convert RTM_GETNEIGHTBL to RCU soon, where we traverse
> tbl->parms_list under RCU in neightbl_dump_info().
>
> Let's use RCU list helper for neigh_parms in neigh_parms_alloc()
> and neigh_parms_release().
>
> neigh_table_init() uses the plain list_add() for the default
> neigh_parm that is embedded in the table and not yet published.
>
> Note that neigh_parms_release() already uses call_rcu() to free
> neigh_parms.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>