netdev - Re: [PATCH v2] selftest: net: fix variable sized type issue not at the end of a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027081937.3b89d06f@kernel.org>
Date: Mon, 27 Oct 2025 08:19:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ankit Khushwaha <ankitkhushwaha.linux@...il.com>
Cc: Steffen Klassert <steffen.klassert@...unet.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, Jason Xing <kernelxing@...cent.com>,
 netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v2] selftest: net: fix variable sized type issue not at
 the end of a struct

On Mon, 27 Oct 2025 11:01:56 +0530 Ankit Khushwaha wrote:
> -		struct cmsghdr cm;
>  		char control[512];
> +		struct cmsghdr cm;

This is no longer in the order in which it will appear in the msg.
If the struct placement is not important just use a raw char buffer
for the whole thing.

Before you repost please read at least the TLDR section of:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
-- 
pw-bot: cr