netdev - Re: [PATCH net-next v2] xsk: add indirect call for xsk_destruct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27083bbd-1ae0-4cd7-ad30-9353dadf2093@intel.com>
Date: Mon, 27 Oct 2025 16:21:11 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jason Xing <kerneljasonxing@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <bjorn@...nel.org>, <magnus.karlsson@...el.com>,
	<maciej.fijalkowski@...el.com>, <jonathan.lemon@...il.com>,
	<sdf@...ichev.me>, <ast@...nel.org>, <daniel@...earbox.net>,
	<hawk@...nel.org>, <john.fastabend@...il.com>, <joe@...a.to>,
	<willemdebruijn.kernel@...il.com>, <bpf@...r.kernel.org>,
	<netdev@...r.kernel.org>, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v2] xsk: add indirect call for xsk_destruct_skb

From: Jason Xing <kerneljasonxing@...il.com>
Date: Sun, 26 Oct 2025 22:58:24 +0800

> From: Jason Xing <kernelxing@...cent.com>
> 
> Since Eric proposed an idea about adding indirect call for UDP and
> managed to see a huge improvement[1], the same situation can also be
> applied in xsk scenario.
> 
> This patch adds an indirect call for xsk and helps current copy mode
> improve the performance by around 1% stably which was observed with
> IXGBE at 10Gb/sec loaded. If the throughput grows, the positive effect
> will be magnified. I applied this patch on top of batch xmit series[2],
> and was able to see <5% improvement from our internal application
> which is a little bit unstable though.
> 
> Use INDIRECT wrappers to keep xsk_destruct_skb static as it used to
> be when the mitigation config is off.
> 
> [1]: https://lore.kernel.org/netdev/20251006193103.2684156-2-edumazet@google.com/
> [2]: https://lore.kernel.org/all/20251021131209.41491-1-kerneljasonxing@gmail.com/
> 
> Suggested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Jason Xing <kernelxing@...cent.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
> v2
> Link: https://lore.kernel.org/all/20251023085843.25619-1-kerneljasonxing@gmail.com/
> 1. use INDIRECT helpers (Alexander)
> ---
>  include/net/xdp_sock.h | 7 +++++++
>  net/core/skbuff.c      | 8 +++++---
>  net/xdp/xsk.c          | 3 ++-
>  3 files changed, 14 insertions(+), 4 deletions(-)
Thanks,
Olek