netdev - Re: [PATCH 1/1] net/mlx5: query_mcia_reg fail logging at debug severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3edcad0c-f9e8-4eeb-bd63-a37d9945a05c@nvidia.com>
Date: Wed, 29 Oct 2025 09:33:39 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Matthew W Carlis <mattc@...estorage.com>
Cc: netdev@...r.kernel.org, saeedm@...dia.com, tariqt@...dia.com,
 mbloch@...dia.com, ashishk@...estorage.com, msaggi@...estorage.com,
 adailey@...estorage.com
Subject: Re: [PATCH 1/1] net/mlx5: query_mcia_reg fail logging at debug
 severity

On 29/10/2025 0:43, Jakub Kicinski wrote:
> On Tue, 28 Oct 2025 13:40:11 -0600 Matthew W Carlis wrote:
>> Whenever a user or automation runs ethtool -m <eth> or an equivalent
>> to mlx5 device & there is not any SFP module in that device the
>> kernel log is spammed with ""query_mcia_reg failed: status:" which
>> is really not that informative to the user who already knows that
>> their command failed. Since the severity is logged at error severity
>> the log message cannot be disabled via dyndbg etc...
> 
> +1 from me FWIW. I wonder if we're hitting this on the same class
> of systems but recently this started hitting at Meta as well.
> Millions of log entries a day because some ports don't have an SFP
> plugged in :|
> 

Allow me to split the discussion to two questions:
1. Is this an error?
2. Should it be logged?

Do we agree that the answer to #1 is yes?

For #2, I think it should, but we can probably improve the situation
with extack instead of a print.