netdev - Re: [PATCH 1/1] net/mlx5: query_mcia_reg fail logging at debug severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d34542b5-6c45-4d73-86db-655b32e00eb1@nvidia.com>
Date: Wed, 29 Oct 2025 09:22:02 +0200
From: Gal Pressman <gal@...dia.com>
To: Matthew W Carlis <mattc@...estorage.com>
Cc: adailey@...estorage.com, ashishk@...estorage.com, mbloch@...dia.com,
 msaggi@...estorage.com, netdev@...r.kernel.org, saeedm@...dia.com,
 tariqt@...dia.com
Subject: Re: [PATCH 1/1] net/mlx5: query_mcia_reg fail logging at debug
 severity

On 28/10/2025 23:48, Matthew W Carlis wrote:
> Tue, 28 Oct 2025 22:27:39, Gal Pressman wrote:
>> And if he knows, I would expect him to not run the command again?
> 
> Sometimes a user is a script or an inventory automation tool. 
> 
>> It is an error, as evident by the fact that you only changed the log
>> level, not the error return value.
> 
> I don't know of any strict convention in terms of when error return codes
> should have associated log messages. I wonder if there is something more targeted
> that could be done. For example, if there is a "physical presence" mechanism
> & a module is not present simply skip the logging.

Maybe the problem is that because we returned zero on error the script
would wrongly continue to try the queries?

Does it stop when an error is detected?