netdev - Re: [PATCH net-next v5 5/5] amd-xgbe: add ethtool jumbo frame selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <462415bb-92dd-418c-9fd6-90f1f3194d68@bootlin.com>
Date: Wed, 29 Oct 2025 21:00:42 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Raju Rangoju <Raju.Rangoju@....com>, netdev@...r.kernel.org
Cc: pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch, Shyam-sundar.S-k@....com
Subject: Re: [PATCH net-next v5 5/5] amd-xgbe: add ethtool jumbo frame
 selftest

Hi Raju,

On 29/10/2025 20:01, Raju Rangoju wrote:
> Adds support for jumbo frame selftest. Works only for
> mtu size greater than 1500.
> 
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
> ---
> Changes since v4:
>  - remove double semicolon
> 
>  drivers/net/ethernet/amd/xgbe/xgbe-dev.c      |  2 ++
>  drivers/net/ethernet/amd/xgbe/xgbe-selftest.c | 23 +++++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> index ffc7d83522c7..b646ae575e6a 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> @@ -211,6 +211,7 @@ static void xgbe_config_sph_mode(struct xgbe_prv_data *pdata)
>  	}
>  
>  	XGMAC_IOWRITE_BITS(pdata, MAC_RCR, HDSMS, XGBE_SPH_HDSMS_SIZE);
> +	pdata->sph = true;
>  }
>  
>  static void xgbe_disable_sph_mode(struct xgbe_prv_data *pdata)
> @@ -223,6 +224,7 @@ static void xgbe_disable_sph_mode(struct xgbe_prv_data *pdata)
>  
>  		XGMAC_DMA_IOWRITE_BITS(pdata->channel[i], DMA_CH_CR, SPH, 0);
>  	}
> +	pdata->sph = false;
>  }

looks like this hunk belongs to the previous patch for split header :)

Maxime