netdev - Re: [PATCH net-next v5 5/5] amd-xgbe: add ethtool jumbo frame selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4376afc2-11e5-4ac6-93d2-0a8170365de6@amd.com>
Date: Thu, 30 Oct 2025 09:39:58 +0530
From: "Rangoju, Raju" <raju.rangoju@....com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>, netdev@...r.kernel.org
Cc: pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch, Shyam-sundar.S-k@....com
Subject: Re: [PATCH net-next v5 5/5] amd-xgbe: add ethtool jumbo frame
 selftest



On 10/30/2025 1:30 AM, Maxime Chevallier wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Raju,
> 
> On 29/10/2025 20:01, Raju Rangoju wrote:
>> Adds support for jumbo frame selftest. Works only for
>> mtu size greater than 1500.
>>
>> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
>> ---
>> Changes since v4:
>>   - remove double semicolon
>>
>>   drivers/net/ethernet/amd/xgbe/xgbe-dev.c      |  2 ++
>>   drivers/net/ethernet/amd/xgbe/xgbe-selftest.c | 23 +++++++++++++++++++
>>   2 files changed, 25 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
>> index ffc7d83522c7..b646ae575e6a 100644
>> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
>> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
>> @@ -211,6 +211,7 @@ static void xgbe_config_sph_mode(struct xgbe_prv_data *pdata)
>>        }
>>
>>        XGMAC_IOWRITE_BITS(pdata, MAC_RCR, HDSMS, XGBE_SPH_HDSMS_SIZE);
>> +     pdata->sph = true;
>>   }
>>
>>   static void xgbe_disable_sph_mode(struct xgbe_prv_data *pdata)
>> @@ -223,6 +224,7 @@ static void xgbe_disable_sph_mode(struct xgbe_prv_data *pdata)
>>
>>                XGMAC_DMA_IOWRITE_BITS(pdata->channel[i], DMA_CH_CR, SPH, 0);
>>        }
>> +     pdata->sph = false;
>>   }
> 
> looks like this hunk belongs to the previous patch for split header :)

My bad. Something seems to have messed up with my sandbox. I'll resend 
the V5 after correcting the hunks. Thanks for point this, Maxime.

> 
> Maxime
>