netdev - Re: [PATCH v5 bpf 1/2] xdp: introduce xdp_convert_skb_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQNWlB5UL+rK8ZE5@boxer>
Date: Thu, 30 Oct 2025 13:14:16 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <bpf@...r.kernel.org>, <ast@...nel.org>, <daniel@...earbox.net>,
	<hawk@...nel.org>, <netdev@...r.kernel.org>, <magnus.karlsson@...el.com>,
	<aleksander.lobakin@...el.com>, <ilias.apalodimas@...aro.org>,
	<toke@...hat.com>, <lorenzo@...nel.org>,
	<syzbot+ff145014d6b0ce64a173@...kaller.appspotmail.com>, Ihor Solodrai
	<ihor.solodrai@...ux.dev>, Octavian Purdila <tavip@...gle.com>
Subject: Re: [PATCH v5 bpf 1/2] xdp: introduce xdp_convert_skb_to_buff()

On Wed, Oct 29, 2025 at 04:50:20PM -0700, Jakub Kicinski wrote:
> On Wed, 29 Oct 2025 23:13:14 +0100 Maciej Fijalkowski wrote:
> > +	xdp->rxq->mem.type = skb->pp_recycle ? MEM_TYPE_PAGE_POOL :
> > +					       MEM_TYPE_PAGE_SHARED;
> 
> You really need to stop sending patches before I had a chance 
> to reply :/ And this is wrong.

Why do you say so?

netif_receive_generic_xdp()
	netif_skb_check_for_xdp()
	skb_cow_data_for_xdp() failed
		go through skb linearize path
			returned skb data is backed by kmalloc, not page_pool,
			means mem type for this particular xdp_buff has to be
			MEM_TYPE_PAGE_SHARED

Are we on the same page now?

> -- 
> pw-bot: cr