netdev - Re: [PATCH net v2] selftests/net: fix out-of-order delivery of FIN in gro:tcp test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.1ebc537b3da9e@gmail.com>
Date: Thu, 30 Oct 2025 08:26:51 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Anubhav Singh <anubhavsinggh@...gle.com>, 
 netdev@...r.kernel.org, 
 linux-kselftest@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Shuah Khan <shuah@...nel.org>, 
 Willem de Bruijn <willemb@...gle.com>, 
 Coco Li <lixiaoyan@...gle.com>, 
 Anubhav Singh <anubhavsinggh@...gle.com>
Subject: Re: [PATCH net v2] selftests/net: fix out-of-order delivery of FIN in
 gro:tcp test

Anubhav Singh wrote:
> Due to the gro_sender sending data packets and FIN packets
> in very quick succession, these are received almost simultaneously
> by the gro_receiver. FIN packets are sometimes processed before the
> data packets leading to intermittent (~1/100) test failures.
> 
> This change adds a delay of 100ms before sending FIN packets
> in gro:tcp test to avoid the out-of-order delivery. The same
> mitigation already exists for the gro:ip test.
> 
> Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test")
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Anubhav Singh <anubhavsinggh@...gle.com>
> ---
> Changes in v2:
>  - Add 'Shuah Khan <shuah@...nel.org>' to the CC list.

Remember to not repost within 24 hours:

https://kernel.org/doc/html/latest/process/maintainer-netdev.html#tl-dr