netdev - Re: [PATCH net-next v16 5/5] net: rnpgbe: Add register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251030081640.694aff44@kernel.org>
Date: Thu, 30 Oct 2025 08:16:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yibo Dong <dong100@...se.com>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, corbet@....net, andrew+netdev@...n.ch,
 danishanwar@...com, vadim.fedorenko@...ux.dev, geert+renesas@...der.be,
 mpe@...erman.id.au, lorenzo@...nel.org, lukas.bulwahn@...hat.com,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v16 5/5] net: rnpgbe: Add register_netdev

On Thu, 30 Oct 2025 10:38:38 +0800 Yibo Dong wrote:
> > >  #include <linux/types.h>
> > >  #include <linux/mutex.h>
> > > +#include <linux/netdevice.h>  
> > 
> > Why do you need to include netdevice.h here now?
> > This patch doesn't add anything that'd need it to the header.
> >   
> 
> It is for 'u8 perm_addr[ETH_ALEN];'
> Maybe I should just "#include <linux/if_ether.h>" for this patch. 

I see, that's fine. Then again, I'm not sure why you store the perm
addr in the struct in the first place. It's already stored in netdevice.