netdev - Re: [PATCH net-next v16 5/5] net: rnpgbe: Add register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24FCCB72DBB477C9+20251030023838.GA2730@nic-Precision-5820-Tower>
Date: Thu, 30 Oct 2025 10:38:38 +0800
From: Yibo Dong <dong100@...se.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	horms@...nel.org, corbet@....net, andrew+netdev@...n.ch,
	danishanwar@...com, vadim.fedorenko@...ux.dev,
	geert+renesas@...der.be, mpe@...erman.id.au, lorenzo@...nel.org,
	lukas.bulwahn@...hat.com, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v16 5/5] net: rnpgbe: Add register_netdev

On Wed, Oct 29, 2025 at 07:21:35PM -0700, Jakub Kicinski wrote:
> On Mon, 27 Oct 2025 11:29:05 +0800 Dong Yibo wrote:
> > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > index 37bd9278beaa..27fb080c0e37 100644
> > --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > @@ -6,6 +6,7 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/mutex.h>
> > +#include <linux/netdevice.h>
> 
> Why do you need to include netdevice.h here now?
> This patch doesn't add anything that'd need it to the header.
> 

It is for 'u8 perm_addr[ETH_ALEN];'
Maybe I should just "#include <linux/if_ether.h>" for this patch. 

> >  enum rnpgbe_boards {
> >  	board_n500,
> > @@ -26,18 +27,38 @@ struct mucse_mbx_info {
> >  	u32 fwpf_ctrl_base;
> >  };
> >  
> > +/* Enum for firmware notification modes,
> > + * more modes (e.g., portup, link_report) will be added in future
> > + **/
> > +enum {
> > +	mucse_fw_powerup,
> > +};
> 
> > +	err = rnpgbe_get_permanent_mac(hw);
> > +	if (err == -EINVAL) {
> > +		dev_warn(&pdev->dev, "Using random MAC\n");
> > +		eth_random_addr(hw->perm_addr);
> > +	} else if (err) {
> > +		dev_err(&pdev->dev, "get perm_addr failed %d\n", err);
> > +		goto err_powerdown;
> > +	}
> > +
> > +	eth_hw_addr_set(netdev, hw->perm_addr);
> 
> This is wrong, you may have gotten random address. This will make it
> look like a real permanent address. Should be:
> 
> 	err = rnpgbe_get_permanent_mac(hw);
> 	if (!err) {
> 		eth_hw_addr_set(netdev, hw->perm_addr);
> 	} else if (err == -EINVAL) {
> 		dev_warn(&pdev->dev, "Using random MAC\n");
> 		eth_hw_addr_random(netdev);
> 		ether_addr_copy(hw->perm_addr, dev->dev_addr);
> 	} else if (err) {
> 		dev_err(&pdev->dev, "get perm_addr failed %d\n", err);
> 		goto err_powerdown;
> 	}
> 

You are right. I will fix this in next version, thanks.