netdev - Re: [PATCH net-next 0/7] convert drivers to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251031184148.1417ac8a@kmaincent-XPS-13-7390>
Date: Fri, 31 Oct 2025 18:41:48 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Sudarsana Kalluru <skalluru@...vell.com>, Manish Chopra
 <manishc@...vell.com>, Marco Crivellari <marco.crivellari@...e.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Sunil Goutham <sgoutham@...vell.com>, Richard
 Cochran <richardcochran@...il.com>, Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <vladimir.oltean@....com>, Simon Horman <horms@...nel.org>,
 Jacob Keller <jacob.e.keller@...el.com>,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/7] convert drivers to use ndo_hwtstamp
 callbacks part 3

On Fri, 31 Oct 2025 18:10:27 +0100
Kory Maincent <kory.maincent@...tlin.com> wrote:

> On Fri, 31 Oct 2025 00:46:00 +0000
> Vadim Fedorenko <vadim.fedorenko@...ux.dev> wrote:
> 
> > This patchset converts the rest of ethernet drivers to use ndo callbacks
> > instead ioctl to configure and report time stamping. The drivers in part
> > 3 originally implemented only SIOCSHWTSTAMP command, but converted to
> > also provide configuration back to users.  
> 
> For these 3 patches, maybe it is better to split them in two to separate the
> NDO conversion from the hwtstamp_get support. I will let Jakub with the final
> word on this.

After a review, I found out that the patches are quite straightforward, so it
is ok to not split them.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com